Re: make LockRelation use top transaction ID

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: make LockRelation use top transaction ID
Date: 2004-07-23 13:49:05
Message-ID: 19662.1090590545@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> I just figured that if we let LockRelation use GetCurrentTransactionId()
> then the wrong thing happens if we let large objects survive
> subtransaction commit/abort.

> So I have changed it to use GetTopTransactionId() instead. Is that OK
> with everybody?

No, at least not if you made that a global change. Doing it that way
will mean that a failed subtransaction will not release its locks, no?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-07-23 14:45:27 Re: Wrong index choosen?
Previous Message Dennis Bjorklund 2004-07-23 12:01:56 Re: Wrong index choosen?