Re: [PATCH] check for ctags utility in make_ctags

From: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Витус Вагнер <vitus(at)wagner(dot)pp(dot)ru>
Subject: Re: [PATCH] check for ctags utility in make_ctags
Date: 2019-01-07 17:42:35
Message-ID: 19586606.0NixFSG4dh@x200m
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

В письме от воскресенье, 6 января 2019 г. 17:50:36 MSK пользователь Andrew
Dunstan написал:

> > The correct way to code this is to depend on the exit code,
> > not the text output:
> >
> > if command -v etags >/dev/null
> > then
> > : ok
> > else
> > echo etags not found
> > exit 1
> > fi
>
> more succinctly,
> command -v etags >/dev/null || { echo etags not found; exit 1;}

If it is good enough for you, then is is good for me for sure...
Imported it to the patch.

Attachment Content-Type Size
check-for-ctags-in-make_ctags_v5.diff text/x-patch 731 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jesper Pedersen 2019-01-07 18:07:18 Re: partitioned tables referenced by FKs
Previous Message Alvaro Herrera 2019-01-07 16:56:48 Re: Problem with parallel_workers option (Was Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead)