Re: Upgrading postmaster's log messages about bind/listen errors

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Joe Conway <mail(at)joeconway(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Upgrading postmaster's log messages about bind/listen errors
Date: 2017-03-10 04:43:23
Message-ID: 19479.1489121003@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Thu, Mar 9, 2017 at 4:01 PM, Joe Conway <mail(at)joeconway(dot)com> wrote:
>> On 03/09/2017 12:27 PM, Tom Lane wrote:
>>> For good measure I also added a DEBUG1 log message reporting successful
>>> binding to a port. I'm not sure if there's an argument for putting this
>>> out at LOG level (i.e. by default) --- any thoughts about that?

>> +1 for making it LOG instead of DEBUG1

> I would tend to vote against that, because startup is getting
> gradually chattier and chattier, and I think this isn't likely to be
> of interest to very many people most of the time.

Yeah, my thought was that if we've gotten along without this for 20 years,
it's probably not of interest to most people most of the time.

However, if we're measuring this on a scale of usefulness to the average
DBA, I would argue that it's of more interest than any of these messages
that currently appear by default:

2017-03-09 23:40:12.334 EST [19335] LOG: MultiXact member wraparound protections are now enabled
2017-03-09 23:40:12.335 EST [19339] LOG: autovacuum launcher started
2017-03-09 23:40:12.336 EST [19341] LOG: logical replication launcher started

The first of those is surely past its sell-by date. As for the other two,
we should log *failure* to start, but not the normal case.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2017-03-10 04:51:59 Re: Logical replication existing data copy
Previous Message Ashutosh Bapat 2017-03-10 04:43:22 Re: Parallel Append implementation