| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org, Jeremy Drake <pgbuildfarm(at)jdrake(dot)com> |
| Subject: | Re: [COMMITTERS] pgsql: Refactor flex and bison make rules |
| Date: | 2012-11-28 23:19:31 |
| Message-ID: | 19170.1354144771@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On 11/28/12 6:01 PM, Tom Lane wrote:
>> I wonder whether adding another .NOTPARALLEL directive would be a better
>> idea than insisting people get hold of patched versions.
> We could put
> ifeq ($(MAKE_VERSION),3.82)
> .NOTPARALLEL:
> endif
> into Makefile.global.
I don't wish to go *that* far. Parallel make works fine for most of the
tree in 3.82, and shutting it off would penalize developers a lot.
It appears to me that the case that okapi is hitting is specific to the
ecpg preprocessor build rules, and indeed specific to the case where
preproc.c needs to be rebuilt. A .NOTPARALLEL in ecpg/preproc/Makefile
would probably be enough to fix it. (I'm a bit tempted to make the one
already added to ecpg/Makefile conditional on the make version, as you
suggest above, too.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2012-11-28 23:29:56 | Re: [HACKERS] pgsql: Refactor flex and bison make rules |
| Previous Message | Andrew Dunstan | 2012-11-28 23:13:52 | Re: pgsql: Refactor flex and bison make rules |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2012-11-28 23:29:56 | Re: [HACKERS] pgsql: Refactor flex and bison make rules |
| Previous Message | Andrew Dunstan | 2012-11-28 23:13:52 | Re: pgsql: Refactor flex and bison make rules |