|From:||Jakob Egger <jakob(at)eggerapps(dot)at>|
|To:||PostgreSQL Packagers <pgsql-packagers(at)postgresql(dot)org>, pgsql-hackers(at)postgresql(dot)org|
|Cc:||Bussmann Tobias <tobias(dot)bussmann(at)scnat(dot)ch>|
|Subject:||Palle Girgensohn's ICU patch|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
When packaging PostgreSQL for Postgres.app, I discovered a problem: strcoll doesn't work for multibyte encodings on OS X. As a consequence, text sorting in PostgreSQL doesn't work. The only workaround seemed to be to use a legacy encoding like latin1, which is inacceptable.
I discovered that OS X shares this limitation with FreeBSD, and there exists a patch written by Palle Girgensohn that uses the ICU library for collating strings instead of the std-c strcoll function. You can find it at http://people.freebsd.org/~girgen/postgresql-icu/README.html <http://people.freebsd.org/~girgen/postgresql-icu/README.html>
I applied the patch, and according to preliminary testing with 9.4rc1 it seems to work flawlessly on OS X as well.
See https://github.com/PostgresApp/PostgresApp/releases/tag/9.4rc1 <https://github.com/PostgresApp/PostgresApp/releases/tag/9.4rc1>
I have two questions:
1) Does anybody else have experience with this patch? Is it safe to release PostgreSQL binaries with this patch applied to the public?
2) Is there a reason why this patch hasn't been merged into core over the years? Since it requires setting a configure switch (--with-icu) it shouldn't break anything?
|Next Message||Palle Girgensohn||2014-11-26 07:41:49||Re: [pgsql-packagers] Palle Girgensohn's ICU patch|
|Previous Message||Michael Paquier||2014-11-26 07:05:26||Re: Function to know last log write timestamp|