| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Improve tab completion for various SET/RESET forms |
| Date: | 2025-06-11 08:34:44 |
| Message-ID: | 18691637-2af2-4a2f-9f12-8201c2a88206@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09.06.25 22:27, Dagfinn Ilmari Mannsåker wrote:
> I noticed that psql tab-completes every possible session-settable
> variable after RESET, not just the ones that have actually been set in
> the current session. However, as I was fixing that I noticed several
> other deficiencies around other forms of SET/RESET. So, here's the
> resulting yak stack.
These technical changes seem fine, but I haven't looked in detail. But
I want to say that I don't like this proposed behavior change at all. I
don't think tab completion should filter out by things that are probably
not interesting or useful depending on session state. That could be
very confusing, especially since there is no surface to explain this
anywhere. The obvious extreme case is that RESET in a fresh session
wouldn't offer any completions at all.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuro Yamada | 2025-06-11 08:36:58 | Re: Add enable_groupagg GUC parameter to control GroupAggregate usage |
| Previous Message | Andrey Rudometov | 2025-06-11 08:26:01 | Fix background workers not restarting with restart_after_crash = on |