| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Indirect indexes |
| Date: | 2016-12-29 14:40:14 |
| Message-ID: | 18672.1483022414@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> One exception: in htup_details.h I changed the definition of
> HeapTupleHeaderIsHeapOnly() so that it returns a true boolean rather
> than a random bit in a wider integer. Without this change, my compiler
> complains when the result is passed as a bool argument into a function.
That should probably get committed as a separate bug fix, and
back-patched. Since HEAP_ONLY_TUPLE is 0x8000, the result of the existing
macro would actually fail to fit into a bool variable, meaning we have a
real coding hazard here. It would be nasty if code developed in HEAD
failed when back-patched because of that.
Andres ran around and fixed a bunch of these hazards before, but
evidently missed this one.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-12-29 14:48:08 | Re: Assignment of valid collation for SET operations on queries with UNKNOWN types. |
| Previous Message | Vik Fearing | 2016-12-29 14:29:56 | French translation encoding |