| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Rounding to even for numeric data type |
| Date: | 2015-07-03 21:06:25 |
| Message-ID: | 18275.1435957585@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> On Sat, May 2, 2015 at 9:53 PM, Fabien COELHO wrote:
>> Quick review: patches applies, make check is fine, all is well.
> Thanks for the feedback, Fabien!
>> All the casting tests could be put in "numeric.sql", as there are all
>> related to numeric and that would avoid duplicating the values lists.
> Not sure about that, the tests are placed here to be consistent with
> for is done for float8.
>> For the documentation, I would also add 3.5 so that rounding to even is even
>> clearer:-)
> Good idea. I reworked the example in the docs.
Pushed with minor adjustments --- you missed updating
int8-exp-three-digits.out, and I thought the documentation wording
could be better.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-07-03 22:03:58 | Re: patch : Allow toast tables to be moved to a different tablespace |
| Previous Message | Jan de Visser | 2015-07-03 20:48:03 | Re: Idea: closing the loop for "pg_ctl reload" |