| From: | "Higuchi, Daisuke" <higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | 'Michael Paquier' <michael(at)paquier(dot)xyz> |
| Cc: | 'Laurenz Albe' <laurenz(dot)albe(at)cybertec(dot)at>, "Sakai, Teppei" <sakai(dot)teppei(at)jp(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Problem during Windows service start |
| Date: | 2019-01-09 08:41:53 |
| Message-ID: | 1803D792815FC24D871C00D17AE95905D7989B@g01jpexmbkw24 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier wrote:
> You should register this patch to the next commit fest in the section for bug fixes to not lose sight of it;
Thank you for picking up my post. I registered to the next CF.
> I haven't put much thoughts into what you propose here, but this status message is not really helpful for the user.
Thank you for review. I attached the updated patch. There are some reasons for server startup failing, so I changed the message like following:
+ case PQPING_NO_RESPONSE:
+ case PQPING_NO_ATTEMPT:
+ write_eventlog(EVENTLOG_ERROR_TYPE, _("Server startup failed. Examine the log output.\n"));
+ pgwin32_SetServiceStatus(SERVICE_STOPPED);
Regards,
Daisuke, Higuchi
| Attachment | Content-Type | Size |
|---|---|---|
| windows_service_bug_fix_v2.patch | application/octet-stream | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2019-01-09 09:01:44 | Re: Displaying and dumping of table access methods |
| Previous Message | Jamison, Kirk | 2019-01-09 08:30:53 | some minor comment fix in md.c |