Re: [Bug fix] PQsendQuery occurs error when target_session_attrs is set to read-write

From: "Higuchi, Daisuke" <higuchi(dot)daisuke(at)jp(dot)fujitsu(dot)com>
To: 'Michael Paquier' <michael(dot)paquier(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [Bug fix] PQsendQuery occurs error when target_session_attrs is set to read-write
Date: 2017-02-02 06:01:55
Message-ID: 1803D792815FC24D871C00D17AE95905AC96BC@g01jpexmbkw24
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

From: Michael Paquier [mailto:michael(dot)paquier(at)gmail(dot)com]
>This has not been added yet to the next CF. As Ashutosh mentioned
>things tend to be easily forgotten. So I have added it here:
>https://commitfest.postgresql.org/13/982/
Thank you for adding this problem to CF.

> I have noticed this typo on the way => s/requisted/requested/:
>--- a/src/interfaces/libpq/fe-connect.c
>+++ b/src/interfaces/libpq/fe-connect.c
>@@ -2908,7 +2908,7 @@ keep_going: /* We will
>come back to here until there is
> }
> /*
>- * If a read-write connection is requisted check for same.
>+ * If a read-write connection is requested check for same.
> */
> if (conn->target_session_attrs != NULL &&
> strcmp(conn->target_session_attrs, "read-write") == 0)
I add this fix to the updated patch.
This is based on the patch Ashutosh updated.

Regards,
Daisuke, Higuchi

Attachment Content-Type Size
PQsendQuery_for_target_session_attrs_v4.patch application/octet-stream 1.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikhil Sontakke 2017-02-02 06:07:20 Re: Speedup twophase transactions
Previous Message Michael Paquier 2017-02-02 05:48:55 Provide list of subscriptions and publications in psql's completion