| From: | Martín Marqués <martin(at)2ndquadrant(dot)com> |
|---|---|
| To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] pg_basebackup --progress output for batch execution |
| Date: | 2017-11-21 10:16:46 |
| Message-ID: | 17c436fe-cd51-a52a-8fa4-ea24298ab59f@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
El 21/11/17 a las 04:56, Arthur Zakirov escribió:
> On Mon, Nov 20, 2017 at 04:45:48PM -0300, Martín Marqués wrote:
>> New version of patch, without the --batch-mode option and using isatty()
>>
>
> Great!
>
>> + fprintf(stderr, "waiting for checkpoint");
>> + if (isatty(fileno(stderr)))
>> + fprintf(stderr, "\n");
>> + else
>> + fprintf(stderr, "\r");
>
> Here the condition should be inverted I think. The next condition should be used:
>
>> if (!isatty(fileno(stderr)))
>> ...
>
> Otherwise pg_basebackup will insert '\n' in terminal instead '\r'.
Ups! Attached the corrected version.:)
Nice catch. I completely missed that. Thanks.
--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| pg_basebackup-using-isatty.patch | text/x-patch | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arthur Zakirov | 2017-11-21 11:11:09 | Re: [HACKERS] pg_basebackup --progress output for batch execution |
| Previous Message | Rajkumar Raghuwanshi | 2017-11-21 10:06:50 | Re: [HACKERS] path toward faster partition pruning |