Re: unknown conversion %m

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unknown conversion %m
Date: 2011-04-28 04:30:16
Message-ID: 17988.1303965016@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> What I'm thinking of doing is to set up something like:
> #define PG_PRINTF_CHECK __printf__
> and on Windows redefine it to __gnu_printf__, and then set all the
> formats to use PG_PRINTF_CHECK.

> Sound OK?

+1 ... those __attribute__ declarations are messy enough already
without wrapping #ifdefs around them. (Don't want to find out
what pgindent would do with that ...)

Possibly PG_PRINTF_ATTRIBUTE would be a better name, but he who
does the work gets to pick.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-04-28 04:44:44 Re: unknown conversion %m
Previous Message Andrew Dunstan 2011-04-28 04:24:10 Re: unknown conversion %m