Skip site navigation (1) Skip section navigation (2)

Re: unknown conversion %m

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: unknown conversion %m
Date: 2011-04-28 04:30:16
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> What I'm thinking of doing is to set up something like:
>     #define PG_PRINTF_CHECK __printf__
> and on Windows redefine it to __gnu_printf__, and then set all the 
> formats to use  PG_PRINTF_CHECK.

> Sound OK?

+1 ... those __attribute__ declarations are messy enough already
without wrapping #ifdefs around them.  (Don't want to find out
what pgindent would do with that ...)

Possibly PG_PRINTF_ATTRIBUTE would be a better name, but he who
does the work gets to pick.

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Tom LaneDate: 2011-04-28 04:44:44
Subject: Re: unknown conversion %m
Previous:From: Andrew DunstanDate: 2011-04-28 04:24:10
Subject: Re: unknown conversion %m

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group