Skip site navigation (1) Skip section navigation (2)

Re: code cleanup: ss_currentScanDesc

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: code cleanup: ss_currentScanDesc
Date: 2010-02-26 06:03:48
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> ScanState.ss_currentScanDesc is currently used by only SeqScan and
> BitmapHeapScan. Other scan nodes don't use the field at all, right?

> Can we move the field into SeqScanState and BitmapHeapScanState
> for code cleanup? This change will not improve any performance,
> but it can clear up what we do actually.

Why is that an improvement?  ISTM that the fact that other scan types
don't use a scandesc pointer is the oddity, not that these do.  You'd
also be making it harder to share any code between these two cases.

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Gokulakannan SomasundaramDate: 2010-02-26 06:09:10
Subject: Re: A thought on Index Organized Tables
Previous:From: Дмитрий ФефеловDate: 2010-02-26 05:55:06
Subject: Re: Alpha4 Available Now

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group