Re: system catalog relation of a table and a serial sequence

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Brent Verner <brent(at)rcfile(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: system catalog relation of a table and a serial sequence
Date: 2001-12-16 04:25:50
Message-ID: 17678.1008476750@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Brent Verner <brent(at)rcfile(dot)org> writes:
> Why not use strtok?

Well, it's ugly (I don't like non-reentrant library routines), it's
not really buying anything, and I don't think you've got the corner
cases right anyway. I'd go for something like

if (strlen(adsrc) > 19 &&
strncmp(adsrc, "nextval('\"", 10) == 0 &&
strcmp(adsrc + strlen(adsrc) - 9, "\"'::text)") == 0)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Brent Verner 2001-12-16 04:38:19 Re: [HACKERS] system catalog relation of a table and a serial sequence
Previous Message Tom Lane 2001-12-16 04:17:54 Re: [HACKERS] system catalog relation of a table and a serial sequence

Browse pgsql-patches by date

  From Date Subject
Next Message Brent Verner 2001-12-16 04:38:19 Re: [HACKERS] system catalog relation of a table and a serial sequence
Previous Message Tom Lane 2001-12-16 04:17:54 Re: [HACKERS] system catalog relation of a table and a serial sequence