Skip site navigation (1) Skip section navigation (2)

Re: Core dump running PL/Perl installcheck with bleadperl [PATCH]

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Core dump running PL/Perl installcheck with bleadperl [PATCH]
Date: 2010-03-07 17:11:26
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com> writes:
> I encountered a core dump running PL/Perl installcheck with a very
> recent git HEAD of PostgreSQL and a not quite so recent git HEAD of perl.

> The cause is a subtle difference between SvTYPE(sv) == SVt_RV and
> SvROK(sv). The former is checking a low-level implementation detail
> while the later is directly checking "does this sv contains a reference".

Hmm.  Seems like this patch begs the question: if checking SvTYPE(*svp)
isn't safe, why is it safe to look at SvTYPE(SvRV(*svp))?  Shouldn't the
tests against SVt_PVHV be made more abstract as well?

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Bruce MomjianDate: 2010-03-07 18:07:49
Subject: Re: incorrect exit code from psql with single transaction + violation of deferred FK constraint
Previous:From: Bruce MomjianDate: 2010-03-07 17:06:31
Subject: Re: Explicit psqlrc

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group