Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])
Date: 2008-04-28 21:07:28
Message-ID: 17166.1209416848@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Hmm, I'm now wondering if the location should be added to Value as well,
> so that it can be passed down to Const?

Just for the record, we don't want it in Const. Parse locations are
only useful in the "raw grammar" output, mainly because they aren't
helpful unless you still have the original query string laying about.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-04-28 21:41:51 Re: WANTED: VACUUM SUMMARY
Previous Message Alvaro Herrera 2008-04-28 21:01:25 Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2008-04-29 02:11:16 Re: [HACKERS] Proposed patch - psql wraps at window width
Previous Message Alvaro Herrera 2008-04-28 21:01:25 Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])