Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

From: stephane tachoires <stephane(dot)tachoires(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>
Subject: Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Date: 2024-03-19 13:06:41
Message-ID: 171085360143.2046436.7217841141682511557.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested

Hi,
I have failing tap test after patches apply:

ok 201 + partition_merge 2635 ms
not ok 202 + partition_split 5719 ms

@@ -805,6 +805,7 @@
(PARTITION salesmans2_3 FOR VALUES FROM (2) TO (3),
PARTITION salesmans3_4 FOR VALUES FROM (3) TO (4),
PARTITION salesmans4_5 FOR VALUES FROM (4) TO (5));
+ERROR: no owned sequence found
INSERT INTO salesmans (salesman_name) VALUES ('May');
INSERT INTO salesmans (salesman_name) VALUES ('Ford');
SELECT * FROM salesmans1_2;
@@ -814,23 +815,17 @@
(1 row)

SELECT * FROM salesmans2_3;
- salesman_id | salesman_name
--------------+---------------
- 2 | Ivanov
-(1 row)
-
+ERROR: relation "salesmans2_3" does not exist
+LINE 1: SELECT * FROM salesmans2_3;

The new status of this patch is: Waiting on Author

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Treat 2024-03-19 13:08:40 Re: DOCS: add helpful partitioning links
Previous Message Alexander Korotkov 2024-03-19 13:05:22 Re: Table AM Interface Enhancements