Re: BRIN indexes vs. SK_SEARCHARRAY (and preprocessing scan keys)

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: BRIN indexes vs. SK_SEARCHARRAY (and preprocessing scan keys)
Date: 2023-06-08 12:03:47
Message-ID: 1701e986-fa32-f3fa-0ac8-39fae8e5db35@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here's a rebased version of this patch series, no other changes.

On 2/25/23 12:45, Tomas Vondra wrote:
> On 2/24/23 22:07, Heikki Linnakangas wrote:
>> I had a quick look at just the preliminary cleanup patches:
>>
>>> 0001-BRIN-bloom-cleanup-20230218.patch
>>
>> Looks good to me
>>
>>> 0002-BRIN-minmax-multi-cleanup-20230218.patch
>>
>> Looks good, although it would feel more natural to me to do it the other
>> way round, and define 'matches' as 'bool matches', and use DatumGetBool.
>>
>
> Yeah, probably. I was trying to only do the minimal change because of
> (maybe) backpatching this.
>

I haven't changed this.

Heikki, do you think these cleanup parts should be backpatched? If yes,
do you still think it should be reworked to do it the other way, or like
I did it do minimize the change?

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
0001-BRIN-bloom-cleanup-20230608.patch text/x-patch 1.9 KB
0002-BRIN-minmax-multi-cleanup-20230608.patch text/x-patch 2.2 KB
0003-Introduce-bloom_filter_size-20230608.patch text/x-patch 3.5 KB
0004-Add-minmax-multi-inequality-tests-20230608.patch text/x-patch 16.8 KB
0005-Introduce-BRIN_PROCNUM_PREPROCESS-procedure-20230608.patch text/x-patch 5.2 KB
0006-Support-SK_SEARCHARRAY-in-BRIN-minmax-20230608.patch text/x-patch 69.5 KB
0007-Support-SK_SEARCHARRAY-in-BRIN-minmax-multi-20230608.patch text/x-patch 75.1 KB
0008-Support-SK_SEARCHARRAY-in-BRIN-inclusion-20230608.patch text/x-patch 22.8 KB
0009-Support-SK_SEARCHARRAY-in-BRIN-bloom-20230608.patch text/x-patch 41.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2023-06-08 12:07:58 Re: Support logical replication of DDLs
Previous Message shveta malik 2023-06-08 12:01:49 Re: Support logical replication of DDLs