Re: POC, WIP: OR-clause support for indexes

From: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
To: Alena Rybakina <lena(dot)ribackina(at)yandex(dot)ru>
Cc: Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, teodor(at)sigaev(dot)ru, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: POC, WIP: OR-clause support for indexes
Date: 2023-07-10 03:12:23
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 7/7/2023 15:20, Alena Rybakina wrote:
> because we will provide similar manipulation in this:
> foreach(l, gentry->consts)
> {
>       Node       *rexpr = (Node *) lfirst(l);
>       rexpr = coerce_to_common_type(pstate, rexpr,
>                                                 scalar_type,
>                                                 "IN");
>      aexprs = lappend(aexprs, rexpr);
> }
I'm not sure that it should be replaced.
In attachment - a bit more corrections to the patch.
The most important change - or_list contains already transformed
expression subtree. So, I think we don't need to free it at all.

Andrey Lepikhov
Postgres Professional

Attachment Content-Type Size
diff-3.diff text/plain 7.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2023-07-10 03:33:48 doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL
Previous Message Thomas Munro 2023-07-10 02:51:37 Re: check_strxfrm_bug()