Re: Making Vars outer-join aware

Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> BTW, inner_join_rels can contain base Relids and OJ Relids. Maybe we
> can revise the comments a bit for it atop deconstruct_recurse and
> make_outerjoininfo. The same for the comments of qualscope, ojscope and
> outerjoin_nonnullable atop distribute_qual_to_rels.

Yeah. I had an XXX comment about whether or not it was okay to
include OJs in inner_join_rels. I took a second look and decided it's
fine, so I removed the XXX and updated these comments.

> The README mentions restriction_is_computable_at(), I think it should be
> clause_is_computable_at().

Right. I think when I wrote that I was imagining that there'd be a
wrapper function specifically concerned with RestrictInfos, but in the
event it didn't seem useful. There's only one place that uses this,
namely subbuild_joinrel_restrictlist.

The cfbot is about to start complaining that this patchset doesn't apply
over e9e26b5e7, so here's a rebase.

regards, tom lane