Re: libpq Win32 Mutex performance patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Chernow <ac(at)esilo(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: libpq Win32 Mutex performance patch
Date: 2008-04-11 22:25:53
Message-ID: 16795.1207952753@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-patches

Andrew Chernow <ac(at)esilo(dot)com> writes:
> A more graceful solution would be to print something to stderr and then
> exit.

stderr doesn't exist, or point to a useful place, in many environments.
And a forced exit() is no better than a crash for most purposes.

> I don't think libpq should core dump an app by choice.

The case that we are talking about is a bug, or would be a bug if it
could happen (the fact that we've gotten along happily with no similar
test in the existing code shows that it can't). Many forms of bug can
result in core dumps; it's foolish to try to prevent them all. And
bloating one line of code into five or more lines to defend against
can't-happen cases is a good way to end up with unreadable,
unmaintainable software.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message daveg 2008-04-11 23:05:06 Re: libpq Win32 Mutex performance patch
Previous Message Andrew Chernow 2008-04-11 21:52:23 Re: libpq Win32 Mutex performance patch