Re: Correction of how to use TimeZone by ControlFile(xlog.c)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Correction of how to use TimeZone by ControlFile(xlog.c)
Date: 2007-08-03 19:34:35
Message-ID: 1670.1186169675@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Tom's idea of a log_timezone seems to make sense.

Here's a preliminary patch for this --- no docs yet, but code is all
there. Seems to work OK. The patch is larger than it'd really have to
be because I chose to rename global_timezone to session_timezone;
I thought it'd be confusing to have something called "global_timezone"
that actually has a narrower scope than "log_timezone".

This wouldn't do for backpatching of course. My inclination for a
backpatch is to just take %Z out of the strftime formats for Windows,
as we did in several places already.

Comments?

regards, tom lane

Attachment Content-Type Size
log_timezone_1.patch.gz application/octet-stream 6.4 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2007-08-03 20:37:43 Re: Async Commit, v21 (now: v22)
Previous Message Magnus Hagander 2007-08-03 18:40:23 Re: Correction of how to use TimeZone by ControlFile(xlog.c)