Re: Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Reserve the shared memory region during backend startup on
Date: 2009-07-28 13:45:57
Message-ID: 16359.1248788757@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Mon, Jul 27, 2009 at 16:14, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I'm not really insisting on a redesign. I'm talking about the places
>> where the code author appears not to have understood that ERROR means
>> FATAL, because the code keeps plugging on after it anyway. As far as
>> I can see, using ERROR at lines 3630, 3657, 3674, and 3693 is just
>> plain bogus, and changing to LOG there requires no other fixing.

> But. I'll look into cleaning those up for HEAD anyway, but due to lack
> of reports I think we should skip backpatch. Reasonable?

Fair enough.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Teodor Sigaev 2009-07-28 13:46:58 Re: pgsql: Correct calculations of overlap and contains operations over
Previous Message Robert Haas 2009-07-28 13:04:32 Re: pgsql: Correct calculations of overlap and contains operations over

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2009-07-28 14:28:46 Re: Review: Revise parallel pg_restore's scheduling heuristic
Previous Message Peter Eisentraut 2009-07-28 13:13:10 Re: SE-PostgreSQL Specifications