| From: | Chengxi Sun <sunchengxi(at)highgo(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Atsushi Torikoshi <torikoshia(at)oss(dot)nttdata(dot)com> |
| Subject: | Re: Is it useful to record whether plans are generic or custom? |
| Date: | 2021-01-22 11:25:40 |
| Message-ID: | 161131474094.8805.3570893985530780135.pgcf@coridan.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: tested, failed
Spec compliant: not tested
Documentation: not tested
Hi Atsushi,
I just run a few test on your latest patch. It works well. I agree with you, I think just tracking generic_calls is enough to get the reason of performance change from pg_stat_statements. I mean if you need more detailed information about the plan and execution of prepared statements, it is better to store this information in a separate view. It seems more reasonable to me.
Regards,
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tang, Haiying | 2021-01-22 11:46:28 | RE: Parallel Inserts in CREATE TABLE AS |
| Previous Message | Peter Eisentraut | 2021-01-22 11:02:11 | Re: [PATCH] Identify LWLocks in tracepoints |