Re: [PATCH] Add features to pg_stat_statements

From: Yuki Seino <seinoyu(at)oss(dot)nttdata(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: yuta katsuragi <btkatsuragiyu(at)oss(dot)nttdata(dot)com>
Subject: Re: [PATCH] Add features to pg_stat_statements
Date: 2020-10-12 12:18:32
Message-ID: 160250511275.1171.7692218521107860164.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed

The patch applies cleanly and looks fine to me. It's a small detail, However wouldn't it be better if the following changes were made.

1.There are unnecessary difference lines 707 and 863 in "pg_stat_statements.c".
2.There is no comment on "slock_t mutex" in "struct pgssCtlCounter" in "pg_stat_statements.c".
3."update_ctl" and "reset_ctl" are generic and illegible name.You might want to rename it something like "pgss_ctl_update".
4.To improve the readability of the source, why not change the function declaration option in "pg_stat_statements_ctl" from
"AS 'MODULE_PATHNAME'" to "AS 'MODULE_PATHNAME', 'pg_stat_statements_ctl'"? in "pg_stat_statements--1.8--1.9.sql".

The new status of this patch is: Waiting on Author

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2020-10-12 12:22:45 Re: [HACKERS] Runtime Partition Pruning
Previous Message Heikki Linnakangas 2020-10-12 12:04:40 Re: archive status ".ready" files may be created too early