|From:||Sergei Kornilov <sk(at)zsrv(dot)org>|
|To:||Michael Paquier <michael(at)paquier(dot)xyz>|
|Cc:||Peter Eisentraut <peter(at)eisentraut(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>|
|Subject:||Re: pgsql: walreceiver uses a temporary replication slot by default|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
> Thanks for posting this patch, Sergei. Here is a review to make
> things move on.
Thank you, here is updated patch
> The set of comments you are removing from walreceiver.c to decide if a
> temporary slot needs to be created or not should be moved to
> walreceiverfuncs.c as you move the logic from the WAL receiver startup
> phase to the moment the WAL receiver spawn is requested.
I changed this comments because they describes behavior during change value of wal_receiver_create_temp_slot.
But yes, I need to add some comments to RequestXLogStreaming.
> It would be more consistent with primary_conn_info and
> primary_slot_name if wal_receiver_create_temp_slot is passed down as
> an argument of RequestXLogStreaming().
Yep, I thought about that. Changed.
> As per the discussion done on this thread, let's also switch the
> parameter default to be disabled.
Done (my vote is also for disabling this option by default).
|Next Message||Peter Eisentraut||2020-02-17 15:14:10||pgsql: Fill in extraUpdatedCols in logical replication|
|Previous Message||Fujii Masao||2020-02-17 07:21:20||pgsql: Add description about GSSOpenServer wait event into document.|
|Next Message||Tom Lane||2020-02-17 14:31:29||Re: Fix compiler warnings on 64-bit Windows|
|Previous Message||Fujii Masao||2020-02-17 13:21:23||Re: Wait event that should be reported while waiting for WAL archiving to finish|