| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Kirk Wolak <wolakk(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Subject: | Re: psql tests hangs |
| Date: | 2023-05-12 19:08:47 |
| Message-ID: | 1555488.1683918527@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
>> Except for testing, using pager in non-interactive mode makes no sense.
> Agreed. Let's solve this by inserting isatty tests in psql, rather
> than hacking the test environment.
Here's a proposed patch for this. I noticed that another memo the
PSQL_WATCH_PAGER patch had not gotten was the lesson learned in
commit 18f8f784c, namely that it's a good idea to ignore empty
or all-blank settings.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| restrict-use-of-PSQL_WATCH_PAGER.patch | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2023-05-12 19:17:00 | Re: psql tests hangs |
| Previous Message | Greg Stark | 2023-05-12 18:58:31 | Re: Should CSV parsing be stricter about mid-field quotes? |