Re: pg_stat_statements vs. SELECT FOR UPDATE

From: Sergei Kornilov <sk(at)zsrv(dot)org>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Subject: Re: pg_stat_statements vs. SELECT FOR UPDATE
Date: 2019-03-12 13:19:27
Message-ID: 155239676712.16480.16065508191585312491.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested

Hello

Patch is applied cleanly, compiles and pass check-world. Has tests and does not need documentation changes since old behavior was not documented
Well, I can not say something about code.

> SELECT * FROM pgss_a JOIN pgss_b ON pgss_b.a_id = pgss_a.id FOR UPDATE OF pgss_a, pgss_b; -- should not appear

This query is counted as second "SELECT * FROM pgss_a JOIN pgss_b ON pgss_b.a_id = pgss_a.id FOR UPDATE". I prefer a bit more verbose comment here. Firstly I was surprised by both questions "why should not appear?" and "where was the second query call?"

regards, Sergei

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2019-03-12 13:20:29 Re: POC: Cleaning up orphaned files using undo logs
Previous Message Michael Paquier 2019-03-12 12:44:03 Re: Offline enabling/disabling of data checksums