Re: DatabaseMetaData patch

From: Rene Pijlman <rpijlman(at)wanadoo(dot)nl>
To: Liam Stewart <liams(at)redhat(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: DatabaseMetaData patch
Date: 2001-08-17 21:17:45
Message-ID: 152rnt0k33g1m6t70eflr5uvpnip0ubp49@4ax.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Fri, 17 Aug 2001 15:59:38 -0400, you wrote:
>Here is a small patch for the DatabaseMetaData class (both jdbc1 and
>jdbc2) that gets the unimplemented methods that should return a
>ResultSet to throw an SQLException -- correct according the JDBC API.
>They used to return null.

Looks good. Fix in 7.2 documented on
http://lab.applinet.nl/postgresql-jdbc/#DatabaseMetaData (work
in progress).

>Also the getTypeInfo method will throw an
>SQLException if the ExecSQL call returns null.

Shouldn't

throw new PSQLException("metadata unavailable");

in getTypeInfo() be something like:

throw new PSQLException("postgresql.meta.unavailable");

to allow translation of the error message in the
errors*.properties files?

Regards,
René Pijlman

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2001-08-17 23:16:43 Re: encoding names
Previous Message John Gray 2001-08-17 20:34:31 New version of XML support routines (0.2)