Re: Loaded footgun open_datasync on Windows

From: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Loaded footgun open_datasync on Windows
Date: 2018-06-08 02:18:44
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Amit Kapila wrote:
> On Wed, Jun 6, 2018 at 3:06 PM, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> wrote:
> > It seems the "#ifndef FRONTEND" restriction was added around
> > pgwin32_open() for building libpq with Visual C++ or Borland C++. The
> > restriction was added in commit 422d4819 to build libpq with VC++[1].
> > Later, in commit fd7c3f67e0bc4, the support for Borland C++ was also
> > added.
> >
> > So, I'm not sure whether removing that restriction will work for all
> > front-end modules.
> >
> Thanks for doing investigation. I agree with you that it appears from the old
> discussion that we have added this restriction to build libpq/psql (basically frontend)
> modules. However, I tried to build those modules on windows by removing that
> restriction and it doesn't give me any problem (except one extra argument error,
> which can be easily resolved). It might be that it gives problem with certain
> version of MSVC. I think if we want to pursue this direction, one needs to verify
> on various supportted versions (of Windows) to see if things are okay.

That's what the buildfarm is for, right?

> Speaking about the issue at-hand, one way to make pg_test_fsync work in to just
> include c.h and remove inclusion of postgres_fe.h, but not sure if that is the best way.
> I am not sure if we have any other options to proceed in this case.
> Thoughts?

I thought of a better way.
pg_test_fsync is properly listed as a server application in the documentation,
so I think it should be built as such, as per the attached patch.

Laurenz Albe

Attachment Content-Type Size
0001-Build-pg_test_fsync-as-backend-code.patch text/x-patch 885 bytes

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-06-08 02:23:56 Re: Add RANGE with values and exclusions clauses to the Window Functions
Previous Message Peter Eisentraut 2018-06-08 02:05:56 config.{guess,sub} updates