Re: Patch for migration of the pg_commit_ts directory

Hello,

I saw a big comment that I had missed.

Added fixes in two patches:

v11-0001-Migration-of-the-pg_commit_ts-directory.patch   - main changes

v11-0002-Migration-of-the-pg_commit_ts-directory-desc.patch - changes to documentation and comments

 

 

----------------

Кому: 'ls7777' (ls7777(at)yandex(dot)ru);

Копия: pgsql-hackers(at)postgresql(dot)org, orlovmg(at)gmail(dot)com;

Тема: Patch for migration of the pg_commit_ts directory;

11.03.2026, 12:55, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>:

Dear Sergey,

 


 I don't understand what I need to do.

Subject: [PATCH v10] Migration of the pg_commit_ts directory

 I have specified a new version in the patch. Do I need to add anything else?

When we see the commit message in postgres repo, you can see that each commit

contain the background, what we did in the commit, considerations, and etc.

Compared with them, the description you added seems insufficient.

Of course the committer will take care, but Amit suggested [1] to write a draft.

The basic style guide is determined in [2].

Actually I wrote a draft for the patch set in v9-0002, but you missed. You may

able to refer it, and re-create new version or use the same one.

[1]: https://www.postgresql.org/message-id/CAA4eK1KMuhaH%3DQgzJCwQgawuybosq-JMWWT9qSqyMZNV1MWjtg%40mail.gmail.com

[2]: https://wiki.postgresql.org/wiki/Commit_Message_Guidance

Best regards,

Hayato Kuroda

FUJITSU LIMITED