|From:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Subject:||Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
PG Bug reporting form <noreply(at)postgresql(dot)org> writes:
> MIPS r6 changes the encoding of LL/SC instruction,
> while the .set mips2 will force assembler to generate
> old encoding.
> In fact if we not willing to support MIPS I or any CPU without ll/sc
> at all, we can just remove .set mips2 here.
After further digging around, I'm liking the alternative of just
removing the ".set mips2" lines. MIPS-I has been obsolete since 1989,
and the MIPS-II instruction set has a lot of other substantial advantages
over MIPS-I besides having LL/SC, so it's pretty hard to believe that
anyone is still using toolchains that default to assuming MIPS-I
Digging around in our archives, it looks like ".set mips2" was required
when it was added, but that was on the strength of testing with a
machine running Linux 2.4.27-r5k-cobalt. We need to research when/if
Linux changed their default configuration.
regards, tom lane
|Next Message||Tom Lane||2019-06-14 00:28:54||Re: BUG #15851: Concurrent Refresh of Materialized views not preserving the order of the underlying query|
|Previous Message||PG Bug reporting form||2019-06-13 19:35:21||BUG #15851: Concurrent Refresh of Materialized views not preserving the order of the underlying query|