Re: [PATCH] sh: Add support Renesas SuperH

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Nobuhiro Iwamatsu <iwamatsu(at)nigauri(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] sh: Add support Renesas SuperH
Date: 2008-04-05 15:58:21
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Nobuhiro Iwamatsu <iwamatsu(at)nigauri(dot)org> writes:
> + __asm__ __volatile__(
> + "tas.b @%1\n\t"
> + "movt %0\n\t"
> + "xor #1,%0"
> +: "=z"(_res)
> +: "r"(lock)
> +: "t","memory");

Another question: this asm declaration ignores the advice given at lines
89-107 of s_lock.h, both cosmetic and substantive. Why? Are you
entirely certain it's right, and not subject to optimization problems in
versions of gcc other than whatever you tested?

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-04-05 18:00:15 Re: Expose checkpoint start/finish times into SQL.
Previous Message Tom Lane 2008-04-05 15:46:49 Re: [PATCH] sh: Add support Renesas SuperH