Re: Improve hash join's handling of tuples with null join keys

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Joel Jacobson <joel(at)compiler(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Improve hash join's handling of tuples with null join keys
Date: 2026-03-19 19:24:36
Message-ID: 1449781.1773948276@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> writes:
> Overall, this looks like a solid patch to me.

Thanks for taking another look.

> The only thing I noticed is that while 0002 fixes the tuple-counting issue, there does not seem to be a test that would fail without it. So I think it would be better to add a test case for 0002. I tried doing that and attached a diff. Without 0002, the test fails; with 0002, it passes.

I couldn't get excited about expending test cycles on that.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message SATYANARAYANA NARLAPURAM 2026-03-19 19:39:18 Re: Read-only connection mode for AI workflows.
Previous Message Masahiko Sawada 2026-03-19 19:24:02 Re: Add uuid_to_base32hex() and base32hex_to_uuid() built-in functions