Re: BUG #6699: pg_restore with -j -- doesn't restore view that groups by primary key

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Ryan Kelly <rpkelly22(at)gmail(dot)com>, joe <joe(at)tanga(dot)com>, Pg Bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #6699: pg_restore with -j -- doesn't restore view that groups by primary key
Date: 2012-06-20 02:56:30
Message-ID: 14428.1340160990@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

I wrote:
> 168; 1259 41968 TABLE public t1 postgres
> ; depends on: 5
> 1921; 2606 41975 CONSTRAINT public t1_pkey postgres
> ; depends on: 168 168
> 169; 1259 41976 VIEW public v1 postgres
> ; depends on: 1919 5
> 1922; 0 41968 TABLE DATA public t1 postgres
> ; depends on: 168

BTW, there's another pretty unpleasant thing going on here, which is
that the t1_pkey constraint is getting hoisted up to before t1's table
data because it is a dependency of v1. That means the index will be
created before the data is loaded, which is not what we want.

Parallel pg_restore actually has a hack that should work around that,
namely repoint_table_dependencies(). That doesn't help for plain serial
restores though. I'm thinking we really ought to bite the bullet and do
something comparable to repoint_table_dependencies() at an appropriate
point in pg_dump, so that the dependencies are sane to begin with.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Craig Ringer 2012-06-20 04:01:41 Re: BUG #5823: launchd execution
Previous Message Tom Lane 2012-06-20 02:34:15 Re: BUG #6699: pg_restore with -j -- doesn't restore view that groups by primary key