Re: Re: [COMMITTERS] pgsql: Augment WAL records for btree delete with GetOldestXmin() to

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> On Fri, 2010-01-29 at 14:04 -0500, Tom Lane wrote:
>> WTF? Simon, this seems to be getting way way beyond anything the
>> community has agreed to. Particularly, inventing GUCs is not something
>> to be doing without consensus.

> If you or anybody else would like me to revoke it then I am happy to do
> that, with no problem or argument. I agree it hasn't had discussion,
> though am happy to have such a discussion.

> The commit is a one line change, with parameter to control it, discussed
> by Heikki and myself in December 2008. I stand by the accuracy of the
> change; the parameter is really to ensure we can test during beta.

Well, I was waiting to see if anyone else had an opinion, but: my
opinion is that a GUC is not appropriate here. Either test it yourself
enough to be sure it's a win, or don't put it in.

regards, tom lane