Re: Changing the state of data checksums in a running cluster

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tomas Vondra <tomas(at)vondra(dot)me>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Bernd Helmle <mailings(at)oopsware(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Changing the state of data checksums in a running cluster
Date: 2026-03-12 22:56:40
Message-ID: 140B5D27-4A0D-42F4-966B-33B66734E594@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 12 Mar 2026, at 00:56, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:

One thing I forgot to mention was that this patch uncovered the same vmap (and
fsm) issue as is being discussed in [0]. At the time I didn't connect the dots
that it was an issue even without this patch so I tried to solve it as part of
this work. After speaking with Andres I ripped out my attempts and will let
the other thread take care of the issue independently of this.

> * The change to XLOG_CHECKPOINT_REDO to move the wal_level into a proper record
> structure should be pulled out as a 0001 patch as it's an cleanup that has
> value on its own.

The attached rebase implements this by putting the XLOG_CHECKPOINT_REDO cleanup
as 0001. This patch could (should?) be applied regardless of the fate of the
rest of the patchset.

--
Daniel Gustafsson

[0] CAAKRu_bn+e7F4yPFBgFbnP+syJRKyNK092bjD2LKvZW7O4Svag(at)mail(dot)gmail(dot)com

Attachment Content-Type Size
v20260313-0002-Online-enabling-and-disabling-of-data-chec.patch application/octet-stream 229.7 KB
v20260313-0001-Add-proper-WAL-record-for-XLOG_CHECKPOINT_.patch application/octet-stream 3.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-03-12 23:34:37 Re: Why clearing the VM doesn't require registering vm buffer in wal record
Previous Message Sami Imseih 2026-03-12 22:44:08 Re: Add missing stats_reset column to pg_statio_all_sequences view