Re: tests for client programs

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tests for client programs
Date: 2014-02-09 03:07:41
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, 2014-01-15 at 20:56 +0100, Erik Rijkers wrote:
> 2 tests stumbled:
> 1. One test ( pg_ctl/t/ ) failed because I had PGDATA set. I unset all PG+ vars after that. No a big
> problem but nonetheless it might be better if the test suite removes /controls the variables before running.
> 2. The pg_isready test failed command_fails() ('fails with no server running') because it defaults to the compiled-in
> server-port (and that server was running). I added the test-designated port (65432, as defined in This
> simple change is in the attached patch.
> With these two changes the whole test suite passed.

Fixed those two things by unsetting environment variables and picking a
different port.

New patch attached.

Attachment Content-Type Size
v2-0001-Add-TAP-tests-for-client-programs.patch text/x-patch 32.8 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2014-02-09 03:16:08 Re: Review: tests for client programs
Previous Message Peter Eisentraut 2014-02-09 02:23:26 Re: clang's -Wmissing-variable-declarations shows some shoddy programming