Re: Doc patch to note which system catalogs have oids

From: "Karl O(dot) Pinc" <kop(at)meme(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Stephen Frost <sfrost(at)snowman(dot)net>
Subject: Re: Doc patch to note which system catalogs have oids
Date: 2012-09-25 02:32:14
Message-ID: 1348540334.1285.0@mofo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 09/24/2012 09:38:53 AM, Karl O. Pinc wrote:
> On 09/23/2012 10:14:33 PM, Tom Lane wrote:
> > "Karl O. Pinc" <kop(at)meme(dot)com> writes:
> > > The attached patch documents the oid column of those
> > > system catalogs having an oid.
> >
> > I think this is fundamentally wrong, or at least misleading,
> because
> > it
> > documents OID as if it were an ordinary column.

> How about modifying the ("printed") table layout as attached?
> It begins each ("printed") table documenting each catalog with a
> "Has OID column" Yes/No.

Changed text from "Has OID column" to "Keyed with an OID column"
since this explains more and there's no worry about horizontal

I like having the documentation of oid be part of the
(printed) table describing the columns, in some way or
another, since that's where the eye is drawn when
looking for column documentation.

Karl <kop(at)meme(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein

Attachment Content-Type Size
oid_doc_v3.patch text/x-patch 18.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-09-25 02:36:32 Re: Patch: incorrect array offset in backend replication tar header
Previous Message Andrew Dunstan 2012-09-25 02:26:46 Re: Oid registry