|From:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|To:||Richard Guo <guofenglinux(at)gmail(dot)com>|
|Subject:||Re: Allowing parallel-safe initplans|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> * For the diff in standard_planner, I was wondering why not move the
> initPlans up to the Gather node, just as we did before. So I tried that
> way but did not notice the breakage of regression tests as stated in the
> comments. Would you please confirm that?
Try it with debug_parallel_query = regress.
> * Not related to this patch. In SS_make_initplan_from_plan, the comment
> says that the node's parParam and args lists remain empty. I wonder if
> we need to explicitly set node->parParam and node->args to NIL before
> that comment, or can we depend on makeNode to initialize them to NIL?
I'm generally a fan of explicitly initializing fields, but the basic
argument for that is greppability. That comment serves the purpose,
so I don't feel a big need to change it.
regards, tom lane
|Next Message||Brar Piening||2023-04-13 14:01:35||Re: doc: add missing "id" attributes to extension packaging page|
|Previous Message||Stephen Frost||2023-04-13 13:26:35||Re: PGBuildfarm member pollock Branch HEAD Failed at Stage Make|