| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Removal of useless include references |
| Date: | 2011-09-01 14:34:46 |
| Message-ID: | 1314887659-sup-1043@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Excerpts from Bruce Momjian's message of jue sep 01 11:04:33 -0300 2011:
> Bruce Momjian wrote:
> > OK, try #2. I already had code that removed #if/#else/#endif code in
> > *.h files for better testing, so I extended that to all *.c files. This
> > reduces the size of the diff from 6.6k lines to 4.7k lines but it makes
> > it much less likely that there will be problems from running
> > pgrminclude.
> >
> > The current patch is here:
> >
> > http://momjian.us/expire/pgrminclude.diff
> >
> > I tested the patch on BSD and Linux.
>
> I have re-run the script and applied the result, again tested on BSD and
> Linux. I will monitor the buildfarm for possible failures.
I think anything of this sort should be tested on Windows too.
--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-09-01 14:40:40 | Re: Removal of useless include references |
| Previous Message | Tom Lane | 2011-09-01 14:10:12 | Re: pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |