Skip site navigation (1) Skip section navigation (2)

avoid including rel.h in execnodes.h

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: avoid including rel.h in execnodes.h
Date: 2011-06-29 23:20:37
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
This simple patch moves two struct declarations (Trigger and
TriggerDesc) from rel.h into a new file, reltrigger.h.  The benefit is
that execnodes.h only needs to include the latter.  Since execnodes.h is
very widely included, this change means there are less files that
indirectly include rel.h now, which is a good thing because rel.h
includes a ton of other files.  (Of course, rel.h itself needs to
include the new header).

I also included rel.h in spi.h, because it was previously indirectly
included via execnodes.h and with this patch it would no longer be,
which is a problem because it'd cause external code to fail to compile.

Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>

Attachment: 0001-Move-Trigger-and-TriggerDesc-structs-out-of-rel.h-in.patch
Description: application/octet-stream (25.1 KB)


pgsql-hackers by date

Next:From: Kevin GrittnerDate: 2011-06-29 23:21:07
Subject: Re: Adding Japanese README
Previous:From: Joe ConwayDate: 2011-06-29 23:18:44
Subject: SECURITY LABEL on shared database object

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group