Re: heap_hot_search_buffer refactoring

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: heap_hot_search_buffer refactoring
Date: 2011-06-19 18:01:10
Message-ID: 1308506470.2597.80.camel@jdavis
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sun, 2011-06-19 at 10:50 -0700, Jeff Davis wrote:
> On Mon, 2011-06-06 at 14:03 -0400, Robert Haas wrote:
> > The attached patch refactors heap_hot_search_buffer() so that
> > index_getnext() can use it, and modifies index_getnext() to do so.
> Attached is a version of the patch that applies cleanly to master.

In heap_hot_search_buffer:

+ /* If this is not the first call, previous call returned
a (live!) tuple */
if (all_dead)
- *all_dead = true;
+ *all_dead = !first_call;

I think that's a typo: it should be:

+ *all_dead = first_call;


Jeff Davis

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2011-06-19 18:08:39 Re: Range Types and extensions
Previous Message Jeff Davis 2011-06-19 17:50:00 Re: heap_hot_search_buffer refactoring