| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Florian G(dot) Pflug" <fgp(at)phlo(dot)org> |
| Cc: | Postgresql-Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: int8 & INT64_IS_BUSTED |
| Date: | 2007-08-29 23:21:53 |
| Message-ID: | 12853.1188429713@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Florian G. Pflug" <fgp(at)phlo(dot)org> writes:
> I still think int8mul is buggy. It calculates result as arg1 * arg2, and then
> checks for an overflow by dividing again, and seeing if the right answer
> comes out. Which sounds good. But it *skips* that check if both arguments
> fit into an int32 - check is
> (arg1 == (int64) ((int32) arg1) && arg2 == (int64) ((int32) arg2)).
Good point --- we should probably #ifdef out that part for
INT64_IS_BUSTED.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-08-29 23:26:09 | Re: Why is there a tsquery data type? |
| Previous Message | Tom Lane | 2007-08-29 23:15:10 | Re: Representation of ResourceOwnerIds (transient XIDs) in system views (lazy xid assignment) |