| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "x4mmm(at)yandex-team(dot)ru" <x4mmm(at)yandex-team(dot)ru>, "a(dot)lubennikova(at)postgrespro(dot)ru" <a(dot)lubennikova(at)postgrespro(dot)ru>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "matsumura(dot)ryo(at)fujitsu(dot)com" <matsumura(dot)ryo(at)fujitsu(dot)com>, "masao(dot)fujii(at)gmail(dot)com" <masao(dot)fujii(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: archive status ".ready" files may be created too early |
| Date: | 2021-08-17 04:25:05 |
| Message-ID: | 1264128B-5757-4A56-974E-45447FC09433@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Attached is a new version of the patch with all feedback addressed.
On 8/16/21, 5:09 PM, "alvherre(at)alvh(dot)no-ip(dot)org" <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> The reason for the latter is that I suspect the segment boundary map
> will also have a use to fix the streaming replication issue I mentioned
> earlier in the thread. This also makes me think that we'll want the wal
> record *start* address to be in the hash table too, not just its *end*
> address. So we'll use the start-1 as position to send, rather than the
> end-of-segment when GetFlushRecPtr() returns that.
I've been thinking about the next steps for this one, too. ISTM we'll
need to basically assume that the flush pointer jumps along record
boundaries except for the cross-segment records. I don't know if that
is the safest assumption, but I think the alternative involves
recording every record boundary in the map.
Nathan
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Avoid-creating-archive-status-.ready-files-too-ea.patch | application/octet-stream | 19.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-08-17 05:00:43 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Michael Paquier | 2021-08-17 04:13:39 | Re: return correct error code from pgtls_init |