Skip site navigation (1) Skip section navigation (2)

Re: [GENERAL] patches

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Travis Bauer <trbauer(at)indiana(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [GENERAL] patches
Date: 2000-06-05 16:09:24
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-patches
Travis Bauer <trbauer(at)indiana(dot)edu> writes:
> What is the appropriate way to submit a patch to a source file.  From what
> I read, I'm supposed to send it here, but do I just attach the changed
> file, or do I send in only the changes? 

Complete files are not good since it's too hard to see what you changed,
and even harder to merge your changes if anyone else has edited the file
since the version you were working from.  Instead, diff -c or diff -u
against the unedited files is the best way.  For example, a u-format
submission would look something like

--- src/backend/utils/adt/arrayfuncs.c.orig    2000/05/30 04:24:50
+++ src/backend/utils/adt/arrayfuncs.c    2000/06/02 15:57:28
@@ -549,11 +549,7 @@
                FILE       *afd;
-#ifndef __CYGWIN32__
-               if ((afd = AllocateFile(accessfile, "r")) == NULL)
-               if ((afd = AllocateFile(accessfile, "r")) == NULL)
+               if ((afd = AllocateFile(accessfile, PG_BINARY_R)) == NULL)
                        elog(ERROR, "unable to open access pattern file");
                *chunkFlag = true;
                retStr = _ChunkArray(*fd, afd, ndim, dim, baseSize, nbytes,

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2000-06-05 16:53:33
Subject: Re: [GENERAL] patches
Previous:From: Travis BauerDate: 2000-06-05 15:05:12
Subject: [GENERAL] patches

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group