| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #4879: bgwriter fails to fsync the file in recovery mode |
| Date: | 2009-06-25 16:27:51 |
| Message-ID: | 1245947271.4038.162.camel@ebony.2ndQuadrant |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, 2009-06-25 at 19:20 +0300, Heikki Linnakangas wrote:
> Simon Riggs wrote:
> >
> But we need to set LocalRecoveryInProgress appropriately
> > also.
>
> Yeah, the trouble is to tell bgwriter that it's OK for it to create the
> checkpoint, which includes writing a WAL record, while still keeping the
> system "in-recovery" for all other purposes. While we could just relax
> the checks, that seems like a very important safeguard.
>
> (I posted in the other mail to do a restartpoint before the startup
> process does the checkpoint)
I think we're in strong agreement, just thinking and writing emails in
realtime gives a few race conditions... your patch covers everything I
mentioned above.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-06-25 16:33:47 | Re: BUG #4879: bgwriter fails to fsync the file in recovery mode |
| Previous Message | Simon Riggs | 2009-06-25 16:22:47 | Re: BUG #4879: bgwriter fails to fsync the file in recovery mode |