Re: [EXTERNAL] Re: [PATCH] Report the query string that caused a memory error under Valgrind

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Onur Tirtir <Onur(dot)Tirtir(at)microsoft(dot)com>
Cc: "peter(dot)eisentraut(at)enterprisedb(dot)com" <peter(dot)eisentraut(at)enterprisedb(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [EXTERNAL] Re: [PATCH] Report the query string that caused a memory error under Valgrind
Date: 2023-04-03 14:19:49
Message-ID: 1222141.1680531589@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Onur Tirtir <Onur(dot)Tirtir(at)microsoft(dot)com> writes:
> Thank you for sharing your proposal as a patch. It looks much nicer and useful than mine.
> I've also tested it for a few cases --by injecting a memory error on purpose-- and seen that it helps reporting the problematic query.
> Should we move forward with v3 then?

OK, I pushed v3 as-is. We can refine it later if anyone has suggestions.

Thanks for the contribution!

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2023-04-03 14:26:30 Re: running logical replication as the subscription owner
Previous Message Pavel Borisov 2023-04-03 14:12:09 Re: POC: Lock updated tuples in tuple_update() and tuple_delete()