Re: [CHECKER] 9 potential out-of-bounds array access errors

Yichen Xie <yxie(at)cs(dot)stanford(dot)edu> writes:
> Both are flagged though--the other one's 85 lines down in the bug report..
> ;) I probably should've sorted the list by location to minimize confusion.

That's okay, I probably should've read the whole mail before commenting ;-)

I'm confused by the entry flagging pl_comp.c:527:

[BUG] is plpgsql_nDatums 0 here? also, sizeof (plpgsql_nDatums) =
2*sizeof(PLpgSQL_datum *)

Is the thing concerned because malloc(0) may yield NULL on some
platforms? If so, should I object that it ought to be smart enough to
know the loop won't execute in that case? Or am I missing something?
Also, I don't understand your comment about the sizeof() relationship.

regards, tom lane