| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Gregory Stark <stark(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, List pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Hint Bits and Write I/O |
| Date: | 2008-06-27 14:53:56 |
| Message-ID: | 1214578436.3845.413.camel@ebony.site |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
On Fri, 2008-06-27 at 15:25 +0100, Gregory Stark wrote:
> "Alvaro Herrera" <alvherre(at)commandprompt(dot)com> writes:
>
> > If only VACUUM is going to set "flexible" to off, maybe it's better to
> > leave the APIs as they are and have a global that's set by VACUUM only
> > (and reset in a PG_CATCH block).
>
> Ugh. Perhaps it would be simpler to have a wrapper function HTSV() macro which
> passes flexible=true to HTSV_internal(). Then vacuum can call HTSV_internal().
>
> I'm not sure what the performance tradeoff is between having an extra argument
> to HTSV and having HTSV check a global which messes with optimizations.
Doing this doesn't actually reduce the size of the patch much, as it
turns out, so I suggest we don't do this.
--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-06-27 15:02:18 | Re: [HACKERS] Hint Bits and Write I/O |
| Previous Message | Jeff McKenna | 2008-06-27 14:53:09 | Re: MSVC 2003 compile error with pg8.3.3 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-06-27 15:02:18 | Re: [HACKERS] Hint Bits and Write I/O |
| Previous Message | Gregory Stark | 2008-06-27 14:36:02 | Re: [HACKERS] Hint Bits and Write I/O |